Refactor error returning timing of doSearch function #1996
Conversation
kpango
changed the title
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
- Coverage 29.63% 29.44% -0.20%
==========================================
Files 365 365
Lines 34245 34429 +184
==========================================
- Hits 10150 10139 -11
- Misses 23676 23871 +195
Partials 419 419
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kpango
force-pushed
the
refactor/gateway-lb/search-error-return-timing
branch
from
7c96933
to
cd0e69f
Compare
Deploying with
|
| Latest commit: |
4203241
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://705f897b.vald.pages.dev |
| Branch Preview URL: | https://refactor-gateway-lb-search-e.vald.pages.dev |
|
[GEN TEST] Failed to generate tests. |
kpango
force-pushed
the
refactor/gateway-lb/search-error-return-timing
branch
from
cd0e69f
to
3cc3cb6
Compare
kpango
force-pushed
the
refactor/gateway-lb/search-error-return-timing
branch
4 times, most recently
from
c25fbce
to
559256e
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
refactor/gateway-lb/search-error-return-timing
branch
from
559256e
to
4203241
Compare
kpango
changed the title
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Fgateway-lb%2Fsearch-error-return-timing/64cfab17d6d670e08d1ff6b597d93b029daeea45 |
Profile Report
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| switch { | ||
| case errs[0] != nil && errs[1] != nil && !Is(errs[0], errs[1]): | ||
| var es []error | ||
| switch x := errs[1].(type) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
type switch on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
| case 1: | ||
| return e.errs[0].Error() | ||
| } | ||
| b := make([]byte, 0, len(e.errs)*16) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 16, in detected (gomnd)
| if errs[0] != nil { | ||
| return errs[0] | ||
| } | ||
| case 2: |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 2, in detected (gomnd)
Description:
LB gateway should use early return error logic for performance, I changed it.
And errors.Join usually uses 1, or 2 errors it should be optimize, I did it.
internal/net/grpc/client span didn't record its error corectly, I fixed it.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: